Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caseByronToBabbageOrConwayEraOnwards #542

Closed
wants to merge 2 commits into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented May 23, 2024

Changelog

- description: |
    Add caseByronToBabbageOrConwayEraOnwards function
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Required for CLI PR: TODO

-> (ConwayEraOnwardsConstraints era => ConwayEraOnwards era -> a)
-> CardanoEra era
-> a
caseByronToBabbageOrConwayEraOnwards l r = \case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi that's redundant - you can achieve the same with inEonForEra, plus you'd have to conjure the constraints conwayEraOnwardsConstraints

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, so closing 👍

@smelc smelc closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants